linux-kernel - Re: [PATCH] of: Fix issue where code would fall through to error case.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Nov 2016 15:40:44 -0800
From:   Frank Rowand <frowand.list@...il.com>
To:     Moritz Fischer <moritz.fischer@...us.com>,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org
Cc:     pantelis.antoniou@...sulko.com, moritz@...e-entropy.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] of: Fix issue where code would fall through to error
 case.

On 11/17/16 15:25, Moritz Fischer wrote:
> No longer fall through into the error case that prints out
> an error if no error (err = 0) occurred.
> 
> Fixes d9181b20a83(of: Add back an error message, restructured)
> Signed-off-by: Moritz Fischer <moritz.fischer@...us.com>
> ---
>  drivers/of/resolver.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
> index 783bd09..785076d 100644
> --- a/drivers/of/resolver.c
> +++ b/drivers/of/resolver.c
> @@ -358,9 +358,13 @@ int of_resolve_phandles(struct device_node *overlay)
>  
>  		err = update_usages_of_a_phandle_reference(overlay, prop, phandle);
>  		if (err)
> -			break;
> +			goto err_out;
>  	}
>  
> +	of_node_put(tree_symbols);
> +
> +	return 0;
> +
>  err_out:
>  	pr_err("overlay phandle fixup failed: %d\n", err);
>  out:

Thanks for catching that.

Rob, please apply.

Reviewed-by: Frank Rowand <frank.rowand@...sony.com>

-Frank