linux-kernel - Re: [RFC PATCH] x86/debug: Dump more detailed segfault info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161118123837.up3f7d5plccrwd25@pd.tnic>
Date:   Fri, 18 Nov 2016 13:38:38 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Andy Lutomirski <luto@...capital.net>
Cc:     Ingo Molnar <mingo@...nel.org>, X86 ML <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC PATCH] x86/debug: Dump more detailed segfault info

On Thu, Nov 17, 2016 at 03:33:21PM -0800, Andy Lutomirski wrote:
> Huh, go figure.  How about access_ok() instead?  There's also
> pagefault_disable() + copy_from_user().

Ah, you don't want to have another #PF during the first one.

How about copy_from_user_nmi()?

It already does __range_not_ok() which is basically access_ok() and
disables #PF around __copy_from_user_inatomic().

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.