linux-kernel - Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161118141540.GH10490@localhost>
Date:   Fri, 18 Nov 2016 15:15:40 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Rahul Krishnan <mrahul.krishnan@...il.com>
Cc:     rmfrfs@...il.com, elder@...nel.org, johan@...nel.org,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for
 single statement block

On Fri, Nov 18, 2016 at 07:04:20PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
> 
> Fixed indentation error, noted by Dan Carpenter
> 
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@...il.com>
> ---
>  drivers/staging/greybus/sdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index f60b458..66b37ea 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
>  	}
>  
>  	if (event & GB_SDIO_WP)
> -	host->read_only = true;
> +		host->read_only = true;

You need to redo your original patch. This one instead looks like a
follow-up to your first revision (which actually removed the braces).

>  
>  	if (state_changed) {
>  		dev_info(mmc_dev(host->mmc), "card %s now event\n",

Thanks,
Johan