linux-kernel - Re: [patch] mmc: mmc_test: Uninitialized return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrOH2h7TXLx8GUr8_nb6DHTqUr9J=ppJM-UJNDaJj-rLw@mail.gmail.com>
Date:   Fri, 18 Nov 2016 15:29:18 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Per Forlin <per.forlin@...aro.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [patch] mmc: mmc_test: Uninitialized return value

On 14 November 2016 at 12:31, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> We never set "ret" to RESULT_OK.
>
> Fixes: 9f9c4180f88d ("mmc: mmc_test: add test for non-blocking transfers")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks, applied for next!

Kind regards
Uffe

>
> diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
> index f61c812..5ba6d77 100644
> --- a/drivers/mmc/card/mmc_test.c
> +++ b/drivers/mmc/card/mmc_test.c
> @@ -832,7 +832,7 @@ static int mmc_test_nonblock_transfer(struct mmc_test_card *test,
>         struct mmc_async_req *other_areq = &test_areq[1].areq;
>         enum mmc_blk_status status;
>         int i;
> -       int ret;
> +       int ret = RESULT_OK;
>
>         test_areq[0].test = test;
>         test_areq[1].test = test;