linux-kernel - Re: [PATCH V8 3/3] stm: Mark the functions of writing buffer with notrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871sy8g83q.fsf@ashishki-desk.ger.corp.intel.com>
Date:   Fri, 18 Nov 2016 16:45:13 +0200
From:   Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:     Chunyan Zhang <zhang.chunyan@...aro.org>, rostedt@...dmis.org,
        mathieu.poirier@...aro.org, mingo@...hat.com
Cc:     mike.leach@....com, tor@...com, philippe.langlais@...com,
        nicolas.guion@...com, felipe.balbi@...ux.intel.com,
        zhang.lyra@...il.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V8 3/3] stm: Mark the functions of writing buffer with notrace

Chunyan Zhang <zhang.chunyan@...aro.org> writes:

> If CONFIG_STM_SOURCE_FTRACE is selected, Function trace data can be writen
> to sink via STM, all functions that related to writing data packets to
> STM should be marked 'notrace' to avoid being traced by Ftrace, otherwise
> the program would stall into an endless loop.
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan@...aro.org>
> Acked-by: Steven Rostedt <rostedt@...dmis.org>
> ---
>  drivers/hwtracing/coresight/coresight-stm.c |  2 +-
>  drivers/hwtracing/intel_th/sth.c            | 11 +++++++----
>  drivers/hwtracing/stm/core.c                |  7 ++++---
>  drivers/hwtracing/stm/dummy_stm.c           |  2 +-
>  include/linux/stm.h                         |  4 ++--
>  5 files changed, 15 insertions(+), 11 deletions(-)

Quick nit: can you please split this one in 4: one for Coresight, one
for Intel TH, one for stm/dummy and one for stm/core?

I'd like to keep the bisectability. Otherwise, this is fine by me:

Acked-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>

Regards,
--
Alex