linux-kernel - Re: [PATCH] sched/rt: Change rt_nr_running to rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161118095307.799fbac8@gandalf.local.home>
Date:   Fri, 18 Nov 2016 09:53:07 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     "T.Zhou" <t1zhou@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the
 comment


Peter,

Can you pull this patch into your queue?

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve


On Fri, 18 Nov 2016 14:39:04 +0800
"T.Zhou" <t1zhou@....com> wrote:

> The code actually checks rt_queued not rt_nr_running
> in pick_next_task_rt(), so change the corresponding
> comment.
> 
> Signed-off-by: T.Zhou <t1zhou@....com>
> ---
>  kernel/sched/rt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 2516b8d..9b4a5c5 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1550,7 +1550,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct pin_cookie coo
>  
>  	/*
>  	 * We may dequeue prev's rt_rq in put_prev_task().
> -	 * So, we update time before rt_nr_running check.
> +	 * So, we update time before rt_queued check.
>  	 */
>  	if (prev->sched_class == &rt_sched_class)
>  		update_curr_rt(rq);