linux-kernel - Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Nov 2016 15:30:40 +0000
From:   Rui Miguel Silva <rmfrfs@...il.com>
To:     Rahul Krishnan <mrahul.krishnan@...il.com>
Cc:     elder@...nel.org, johan@...nel.org, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single
 statement block

Hi Rahul,
Thanks for the patch.
Now looks great.

On Fri, Nov 18, 2016 at 08:45:25PM +0530, Rahul Krishnan wrote:
>This patch fixes the following checkpath.pl warning
>WARNING: braces {} are not necessary for single statement blocks
>
>
>Signed-off-by: Rahul Krishnan <mrahul.krishnan@...il.com>

Reviewed-by: Rui Miguel Silva <rmfrfs@...il.com>

>---
> drivers/staging/greybus/sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
>index 5649ef1..66b37ea 100644
>--- a/drivers/staging/greybus/sdio.c
>+++ b/drivers/staging/greybus/sdio.c
>@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
> 		state_changed = 1;
> 	}
>
>-	if (event & GB_SDIO_WP) {
>+	if (event & GB_SDIO_WP)
> 		host->read_only = true;
>-	}
>
> 	if (state_changed) {
> 		dev_info(mmc_dev(host->mmc), "card %s now event\n",
>-- 
>2.10.2
>