linux-kernel - [PATCH] phy: rockchip-inno-usb2: add extcon dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Nov 2016 17:36:26 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Guenter Roeck <groeck@...omium.org>,
        Frank Wang <frank.wang@...k-chips.com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] phy: rockchip-inno-usb2: add extcon dependency

If extcon is a loadable module and rockchip-inno-usb2 is built-in,
we get a link failure:

drivers/phy/phy-rockchip-inno-usb2.o: In function `rockchip_usb2phy_probe':
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x1ec): undefined reference to `extcon_get_edev_by_phandle'
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x25c): undefined reference to `devm_extcon_dev_allocate'
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x2a8): undefined reference to `devm_extcon_dev_register'
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0xa28): undefined reference to `extcon_register_notifier'

Adding a hard dependency avoids the problem. Alternatively we could
use "depends on EXTCON || !EXTCON" to allow building with extcon
disabled completely, but the other PHY drivers with extcon support
also just have a dependency, so this is more consistent.

Fixes: 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 53cab9f3323b..b135ff1ab12d 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -366,6 +366,7 @@ config PHY_ROCKCHIP_INNO_USB2
 	depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
 	depends on COMMON_CLK
 	depends on USB_SUPPORT
+	depends on EXTCON
 	select GENERIC_PHY
 	select USB_COMMON
 	help
-- 
2.9.0