linux-kernel - RE: [PATCH 21/29] radix-tree: Delete radix_tree_locate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN1PR21MB00771B7E1F66DE0A62F2FDD7CBB00@SN1PR21MB0077.namprd21.prod.outlook.com>
Date:   Fri, 18 Nov 2016 16:34:05 +0000
From:   Matthew Wilcox <mawilcox@...rosoft.com>
To:     Konstantin Khlebnikov <koct9i@...il.com>,
        Matthew Wilcox <mawilcox@...uxonhyperv.com>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: RE: [PATCH 21/29] radix-tree: Delete radix_tree_locate_item()

From: Konstantin Khlebnikov [mailto:koct9i@...il.com]
> On Thu, Nov 17, 2016 at 3:17 AM, Matthew Wilcox
> <mawilcox@...uxonhyperv.com> wrote:
> > This rather complicated function can be better implemented as an iterator.
> > It has only one caller, so move the functionality to the only place that
> > needs it.  Update the test suite to follow the same pattern.
> 
> Looks good. I suppose this patch could be applied separately.

Yes, a number of these patches stand alone from each other and could easily be separated out.
I'm going to put your Reviewed-by: on the patches you've said "Looks good" to.  Thanks!