linux-kernel - Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2756474.23HNgnMOUG@wuerfel>
Date:   Fri, 18 Nov 2016 17:57:55 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #2]

On Friday, November 18, 2016 4:20:38 PM CET David Howells wrote:
> Add a system call to make extended file information available, including
> file creation and some attribute flags where available through the
> underlying filesystem.

Looks great!

Is there still hope of scheduling this for v4.10, or are you
planning it for v4.11 at this point?

> ========
> OVERVIEW
> ========
> 
> The idea was initially proposed as a set of xattrs that could be retrieved
> with getxattr(), but the general preferance proved to be for a new syscall
> with an extended stat structure.
> 
> This has a number of uses:
...
> 
> Note that not all of the above are implemented here.

It's good to have the whole list of possible features here, but
the list of features that are actually implemented is probably
more important for the changelog. You seem to have that list
in the introductory mail but not in the actual patch.


> -       stat->atime = inode->i_atime;
> 
>         stat->mtime = inode->i_mtime;
>         stat->ctime = inode->i_ctime;
> 
> -       stat->blksize = (1 << inode->i_blkbits);
> +       stat->size = i_size_read(inode);
> 
>         stat->blocks = inode->i_blocks;
> 
> -}
> +       stat->blksize = 1 << inode->i_blkbits;
> 
> +       stat->result_mask |= STATX_BASIC_STATS;
> +       if (IS_NOATIME(inode))
> +               stat->result_mask &= ~STATX_ATIME;
> +       else
> +               stat->atime = inode->i_atime;

This looks like you are changing the behavior of the existing
stat call to no longer return the atime from the on-disk
inode if NOATIME is set.

Is my interpretation correct, and is this an intentional
change?

	Arnd