linux-kernel - Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4g7_kDAZNZ2ikBRgFsX-hFpcXEV2xg9YS0Ha7PjSBkzVQ@mail.gmail.com>
Date:   Thu, 17 Nov 2016 17:53:31 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     John Garry <john.garry@...wei.com>
Cc:     jejb@...ux.vnet.ibm.com,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        wangyijing <wangyijing@...wei.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        John Garry <john.garry2@...l.dcu.ie>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linuxarm@...wei.com, lindar_liu@...sh.com,
        Tejun Heo <tj@...nel.org>,
        Jinpu Wang <jinpu.wang@...fitbricks.com>
Subject: Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Thu, Nov 17, 2016 at 7:23 AM, John Garry <john.garry@...wei.com> wrote:
> On 11/11/2016 08:49, wangyijing wrote:
>>>>>
>>>>> I have not seen the flutter issue. I am just trying to solve the
>>>>> horrible WARN dump.
>>>>> However I do understand that there may be a issue related to how we
>>>>> queue the events; there was a recent attempt to fix this, but it came to
>>>>> nothing:
>>>>> https://www.spinics.net/lists/linux-scsi/msg99991.html
>>>>
>>>>
>>>> We found libsas hotplug several problems:
>>>> 1. sysfs warning calltrace(like the case you found);
>>>
>>>
>>> Maybe you can then review my patch.
>>
>>
>> I did it, I think your solution to fix the sysfs calltrace issue is ok,
>> and what I worried about is we still need to fix
>> the rest issues. So it's better if we could fix all issues one time.
>>
>
> @Maintainers, would you be willing to accept this patch as an interim fix
> for the dastardly WARN while we try to fix the flutter issue?

To me this adds a bug to quiet a benign, albeit noisy, warning.