linux-kernel - Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d1b0863-8c51-079a-b74e-8950c51060ff@redhat.com>
Date:   Fri, 18 Nov 2016 19:20:50 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and
 kvm_arch_set_irq_inatomic

Am 17.11.2016 um 15:55 schrieb Paolo Bonzini:
> kvm_arch_set_irq is unused since commit b97e6de9c96.  Merge
> its functionality with kvm_arch_set_irq_inatomic.
>
> Reported-by: Jiang Biao <jiang.biao2@....com.cn>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---

As you said, it is unused. Therefore the functionality is superfluous. 
Why merge it?

We can still introduce this later if we ever need it. Or do you have a 
concrete user in mind?

The patch in general looks good to me. Just wondering if we can't simply 
rip out that single function.

-- 

David