lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Nov 2016 14:13:26 -0500 (EST) From: David Miller <davem@...emloft.net> To: arnd@...db.de Cc: jiri@...lanox.com, idosch@...lanox.com, ivecera@...hat.com, eladr@...lanox.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency From: Arnd Bergmann <arnd@...db.de> Date: Fri, 18 Nov 2016 17:01:14 +0100 > The newly added switchib driver fails to link if MLXSW_PCI=m: > > drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function^Cmlxsw_sib_module_exit': > switchib.c:(.exit.text+0x8): undefined reference to `mlxsw_pci_driver_unregister' > switchib.c:(.exit.text+0x10): undefined reference to `mlxsw_pci_driver_unregister' > drivers/net/ethernet/mellanox/mlxsw/mlxsw_switchib.o: In function `mlxsw_sib_module_init': > switchib.c:(.init.text+0x28): undefined reference to `mlxsw_pci_driver_register' > switchib.c:(.init.text+0x38): undefined reference to `mlxsw_pci_driver_register' > switchib.c:(.init.text+0x48): undefined reference to `mlxsw_pci_driver_unregister' > > The other two such sub-drivers have a dependency, so add the same one > here. In theory we could allow this driver if MLXSW_PCI is disabled, > but it's probably not worth it. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> Please resubmit this with a proper fixes tag that identifies the commit that added the switchib driver. Thanks.
Powered by blists - more mailing lists