linux-kernel - Re: [PATCH 1/2] sunqe: Fix compiler warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161118.142942.620136274318885678.davem@davemloft.net>
Date:   Fri, 18 Nov 2016 14:29:42 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tushar.n.dave@...cle.com
Cc:     sparclinux@...r.kernel.org, chris.hyser@...cle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] sunqe: Fix compiler warnings

From: Tushar Dave <tushar.n.dave@...cle.com>
Date: Mon, 17 Oct 2016 13:56:59 -0700

> sunqe uses '__u32' for dma handle while invoking kernel DMA APIs,
> instead of using dma_addr_t. This hasn't caused any 'incompatible
> pointer type' warning on SPARC because until now dma_addr_t is of
> type u32. However, recent changes in SPARC ATU (iommu) enables 64bit
> DMA and therefore dma_addr_t becomes of type u64. This makes
> 'incompatible pointer type' warnings inevitable.
> 
> e.g.
> drivers/net/ethernet/sun/sunqe.c: In function ‘qec_ether_init’:
> drivers/net/ethernet/sun/sunqe.c:883: warning: passing argument 3 of ‘dma_alloc_coherent’ from incompatible pointer type
> ./include/linux/dma-mapping.h:445: note: expected ‘dma_addr_t *’ but argument is of type ‘__u32 *’
> drivers/net/ethernet/sun/sunqe.c:885: warning: passing argument 3 of ‘dma_alloc_coherent’ from incompatible pointer type
> ./include/linux/dma-mapping.h:445: note: expected ‘dma_addr_t *’ but argument is of type ‘__u32 *’
> 
> This patch resolves above compiler warnings.
> 
> Signed-off-by: Tushar Dave <tushar.n.dave@...cle.com>
> Reviewed-by: chris hyser <chris.hyser@...cle.com>

Aplpied.