linux-kernel - Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFTL4hwet4+rm+y=EX=K1G+x7G+qk0+un8X4K2dJ3QBTeNbttw@mail.gmail.com>
Date:   Sat, 19 Nov 2016 16:49:46 +0100
From:   Frederic Weisbecker <fweisbec@...il.com>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     "the arch/x86 maintainers" <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible

2016-11-18 18:46 GMT+01:00 Josh Poimboeuf <jpoimboe@...hat.com>:
> NMI stack dumps are bracked by the following tags:
>
>   <NMI>
>   ...
>   <EOE>
>
> The ending tag is kind of confusing if you don't already know what "EOE"
> means (end of exception).  The same ending tag is also used to mark the
> end of all other exceptions' stacks.  For example:
>
>   <#DF>
>   ...
>   <EOE>
>
> And similarly, "EOI" is used as the ending tag for interrupts:
>
>   <IRQ>
>   ...
>   <EOI>
>
> Change the tags to be more comprehensible by making them symmetrical and
> more XML-esque:
>
>   <NMI>
>   ...
>   </NMI>
>
>   <#DF>
>   ...
>   </#DF>
>
>   <IRQ>
>   ...
>   </IRQ>
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>

I like that! I hope not too many tools rely on the old namings.
But dmesg isn't supposed to be a stable ABI anyway.

Acked-by: Frederic Weisbecker <fweisbec@...il.com>