linux-kernel - Re: [v3,3/3] hwmon: (mcp3021) replace S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161119162945.GA15441@roeck-us.net>
Date:   Sat, 19 Nov 2016 08:29:45 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Clemens Gruber <clemens.gruber@...ruber.com>
Cc:     linux-hwmon@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [v3,3/3] hwmon: (mcp3021) replace S_IRUGO with 0444

On Wed, Nov 09, 2016 at 06:16:14PM +0100, Clemens Gruber wrote:
> Replace S_IRUGO with the better readable 0444.
> This fixes a checkpatch warning.
> 
> Signed-off-by: Clemens Gruber <clemens.gruber@...ruber.com>

Applied to -next.

Guenter

> ---
>  drivers/hwmon/mcp3021.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/mcp3021.c b/drivers/hwmon/mcp3021.c
> index 81f4b7f..3a007ab 100644
> --- a/drivers/hwmon/mcp3021.c
> +++ b/drivers/hwmon/mcp3021.c
> @@ -102,7 +102,7 @@ static ssize_t show_in_input(struct device *dev, struct device_attribute *attr,
>  	return sprintf(buf, "%d\n", in_input);
>  }
>  
> -static DEVICE_ATTR(in0_input, S_IRUGO, show_in_input, NULL);
> +static DEVICE_ATTR(in0_input, 0444, show_in_input, NULL);
>  
>  static int mcp3021_probe(struct i2c_client *client,
>  				const struct i2c_device_id *id)