linux-kernel - Re: [patch v8 1/1] i2c: add master driver for mellanox systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161119210444.GB2856@katana>
Date:   Sat, 19 Nov 2016 22:04:44 +0100
From:   Wolfram Sang <wsa-dev@...g-engineering.com>
To:     vadimp@...lanox.com
Cc:     wsa@...-dreams.de, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, jiri@...nulli.us,
        Michael Shych <michaelsh@...lanox.com>
Subject: Re: [patch v8 1/1] i2c: add master driver for mellanox systems

Hi,

looks mostly good. I just found this comment which needs clarification:

> +	/*
> +	 * All upper layers currently are never use transfer with more than
> +	 * 2 messages.

Have you really checked ALL of the upper layers? And even if so, there
is the dev-interface to userspace which allows for arbitrary I2C
transfers using I2C_RDWR.

>  Actually, it's also not so relevant in Mellanox systems
> +	 * because of HW limitation.

What kind of HW limitation do you mean here? Can Mellanox send more than
two messages?

> Max size of transfer is o more than 20B

"is o more"? Typo?

> +	 * in current x86 LPCI2C bridge.

What does that mean in result?

Regards,

   Wolfram

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)