linux-kernel - Re: [PATCH 3.16 327/346] mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1479604438.16599.19.camel@decadent.org.uk>
Date:   Sun, 20 Nov 2016 01:13:58 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        akpm@...ux-foundation.org,
        Antonio SJ Musumeci <trapexit@...wn.link>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 3.16 327/346] mm: workingset: fix crash in shadow node
 shrinker caused by replace_page_cache_page()

On Mon, 2016-11-14 at 10:42 -0500, Johannes Weiner wrote:
> On Mon, Nov 14, 2016 at 12:14:20AM +0000, Ben Hutchings wrote:
> > 3.16.39-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Johannes Weiner <hannes@...xchg.org>
> > 
> > commit 22f2ac51b6d643666f4db093f13144f773ff3f3a upstream.
[...]
> The added sanity checks in this patch can crash kernels built with
> CONFIG_DEBUG_VM. While I doubt many people run 3.16 with that enabled,
> please also consider taking the following two changes. The first one
> changes the new VM_BUG_ONs to mere warnings, and the second patch
> addresses the underlying issue that triggered them in the first place.
> 
> 21f54ddae449 Using BUG_ON() as an assert() is _never_ acceptable
> d3798ae8c6f3 mm: filemap: don't plant shadow entries without radix tree node
> 
> Attaching the latter below, since it's drastically different than the
> upstream change, but a lot simpler because it predates the DAX stuff.
[...]

Thanks, I've added these two.

Ben.

-- 
Ben Hutchings
Lowery's Law:
             If it jams, force it. If it breaks, it needed replacing
anyway.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)