lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Nov 2016 22:13:25 +0100 From: Marek Vasut <marek.vasut@...il.com> To: Luis Henriques <henrix@...andro.org>, David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, Boris Brezillon <boris.brezillon@...e-electrons.com>, Richard Weinberger <richard@....at>, Cyrille Pitchen <cyrille.pitchen@...el.com> Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mtd: maps: add missing iounmap() in error path On 11/16/2016 11:50 PM, Luis Henriques wrote: > This patch was triggered by the following Coccinelle error: > > ./drivers/mtd/maps/sc520cdp.c:246:3-9: \ > ERROR: missing iounmap; ioremap on line 242 \ > and execution via conditional on line 244 > > Signed-off-by: Luis Henriques <henrix@...andro.org> Reviewed-by: Marek Vasut <marek.vasut@...il.com> > --- > drivers/mtd/maps/sc520cdp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mtd/maps/sc520cdp.c b/drivers/mtd/maps/sc520cdp.c > index 093edd51bdc7..7a27ed345d0d 100644 > --- a/drivers/mtd/maps/sc520cdp.c > +++ b/drivers/mtd/maps/sc520cdp.c > @@ -243,6 +243,10 @@ static int __init init_sc520cdp(void) > > if (!sc520cdp_map[i].virt) { > printk("Failed to ioremap_nocache\n"); > + if (i) { > + while (--i) > + iounmap(sc520cdp_map[i].virt); > + } > return -EIO; > } > > -- Best regards, Marek Vasut
Powered by blists - more mailing lists