linux-kernel - Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87shqlw6vx.fsf@concordia.ellerman.id.au>
Date:   Mon, 21 Nov 2016 19:53:54 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     "Zhangjian \(Bamvor\)" <bamvor.zhangjian@...wei.com>,
        shuahkh@....samsung.com
Cc:     linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
        khilman@...aro.org, broonie@...nel.org,
        Bamvor Zhang Jian <bamvor.zhangjian@...aro.org>
Subject: Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target

"Zhangjian (Bamvor)" <bamvor.zhangjian@...wei.com> writes:
> On 2016/11/18 18:31, Michael Ellerman wrote:
>  >bamvor.zhangjian@...wei.com writes:
>  >> From: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
>  >> Currently, kselftest use TEST_PROGS, TEST_PROGS_EXTENDED, TEST_FILES to
>  >> indicate the default test program, extended test program and test files.
>  >> These lead to duplicated all and clean targets.
>  >>
>  >> In order to remove them, introduce TEST_GEN_PROGS,
>  >> TEST_GEN_PROGS_EXTENDED, TEST_GEN_FILES to indicate the compiled
>  >> objected.
>  >
>  >It's nice to be able to drop the clean rules, but renaming all those
>  >variables causes a lot of churn.
>  >
>  >I think it would be better if we add a new variable, maybe NO_CLEAN,
>  >which can be used to specify anything in TEST_PROGS/EXTENDED which
>  >should *not* be cleaned.
>  >
>  >And then the default clean rule will just do:
>  >
>  >clean:
>  >    $(RM) -fr $(filter-out $(NO_CLEAN),$(TEST_PROGS))

> Maybe I lost somewhere. I add these variable for all and
> clean target. They will be used to output the objects to OUTPUT
> directory.

No you're right, that won't work as I described it.

I reviewed this patch first and didn't look at how it was required for
patch 6 to work (and the change log doesn't mention that you need it for
patch 6 :)

> Could you please explain in details how should I do it for
> "all" target if I do not introduce TEST_GEN_PROGS,
> TEST_GEN_PROGS_EXTENDED and TEST_GEN_FILES?

I'll have to think about it a bit more.

cheers