linux-kernel - Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1611210954090.3514@nanos>
Date:   Mon, 21 Nov 2016 09:56:00 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Baolin Wang <baolin.wang@...aro.org>
cc:     Ingo Molnar <mingo@...nel.org>,
        John Stultz <john.stultz@...aro.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Richard Cochran <richardcochran@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for
 alarmtimer

On Mon, 21 Nov 2016, Baolin Wang wrote:
> On 21 November 2016 at 16:13, Ingo Molnar <mingo@...nel.org> wrote:
> > Hm, there's a weirdness here: if freezer_delta != 0 when alarmtimer_suspend() is
> > called then type might be '0', although it's not alarm_bases[0] this value is
> > picked up from.
> >
> > Wouldn't it be better to initialize 'type' to -1 instead? (And rename it to
> > min_type or so.)
> 
> Make sense. I will send out new patch to fix this. Thanks for your comments.

Can you please fix the subject line while at it? 'trcepoints' does not look right

Thanks,

	tglx