linux-kernel - Re: undefined reference to `devm_watchdog_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161121131734.GJ1446@lahna.fi.intel.com>
Date:   Mon, 21 Nov 2016 15:17:34 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Vegard Nossum <vegard.nossum@...il.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: undefined reference to `devm_watchdog_register_device'

On Mon, Nov 21, 2016 at 02:04:34PM +0100, Rafael J. Wysocki wrote:
> On Mon, Nov 21, 2016 at 10:07 AM, Vegard Nossum <vegard.nossum@...il.com> wrote:
> > Hi,
> >
> > I updated my config and set CONFIG_WDAT_WDT=y, got this:
> >
> > drivers/built-in.o: In function `wdat_wdt_probe':
> > /home/vegard/linux/drivers/watchdog/wdat_wdt.c:444: undefined
> > reference to `devm_watchdog_register_device'
> > Makefile:962: recipe for target 'vmlinux' failed
> > make: *** [vmlinux] Error 1
> >
> > Looks like it's missing a select for WATCHDOG_CORE in the Kconfig?
> 
> Mika?

That's right - we should select WATCHDOG_CORE there.

I'll submit a patch fixing this shortly.