linux-kernel - Re: [PATCH] USB: serial: cp210x: Use tcflag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161121145845.GA27409@localhost>
Date:   Mon, 21 Nov 2016 15:58:45 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: cp210x: Use tcflag_t to fix incompatible
 pointer type

On Mon, Nov 21, 2016 at 01:19:31PM +0100, Geert Uytterhoeven wrote:
> On sparc32, tcflag_t is unsigned long, unlike all other architectures:
> 
>     drivers/usb/serial/cp210x.c: In function 'cp210x_get_termios':
>     drivers/usb/serial/cp210x.c:717:3: warning: passing argument 2 of 'cp210x_get_termios_port' from incompatible pointer type
>        cp210x_get_termios_port(tty->driver_data,
>        ^
>     drivers/usb/serial/cp210x.c:35:13: note: expected 'unsigned int *' but argument is of type 'tcflag_t *'
>      static void cp210x_get_termios_port(struct usb_serial_port *port,
> 		 ^
> 
> Consistently use tcflag_t to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied for -next as this an old warning for something that should be
benign on 32-bit.

Thanks,
Johan