linux-kernel - Re: [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1531291.6pVMOmFLZP@vostro.rjw.lan>
Date:   Mon, 21 Nov 2016 23:29:20 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     linux-pci@...r.kernel.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Lukas Wunner <lukas@...ner.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port

On Monday, November 21, 2016 03:45:26 PM Bjorn Helgaas wrote:
> We already log a "Signaling PME" whenever the PME service driver claims a
> Root Port.  In fact, we also log the same message for every device in the
> hierarchy below the Root Port.
> 
> Log the "Signaling PME" once (only for the Root Port, since we can
> trivially find out which devices are below the Root Port), and include the
> IRQ number in the message to help connect the dots with /proc/interrupts.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> ---
>  drivers/pci/pcie/pme.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
> index 9e8aa9d..7175293 100644
> --- a/drivers/pci/pcie/pme.c
> +++ b/drivers/pci/pcie/pme.c
> @@ -300,8 +300,6 @@ static irqreturn_t pcie_pme_irq(int irq, void *context)
>   */
>  static int pcie_pme_set_native(struct pci_dev *dev, void *ign)
>  {
> -	dev_info(&dev->dev, "Signaling PME through PCIe PME interrupt\n");
> -
>  	device_set_run_wake(&dev->dev, true);
>  	dev->pme_interrupt = true;
>  	return 0;
> @@ -349,12 +347,14 @@ static int pcie_pme_probe(struct pcie_device *srv)
>  	ret = request_irq(srv->irq, pcie_pme_irq, IRQF_SHARED, "PCIe PME", srv);
>  	if (ret) {
>  		kfree(data);
> -	} else {
> -		pcie_pme_mark_devices(port);
> -		pcie_pme_interrupt_enable(port, true);
> +		return ret;
>  	}
>  
> -	return ret;
> +	dev_info(&port->dev, "Signaling PME with IRQ %d\n", srv->irq);
> +
> +	pcie_pme_mark_devices(port);
> +	pcie_pme_interrupt_enable(port, true);
> +	return 0;
>  }
>  
>  static bool pcie_pme_check_wakeup(struct pci_bus *bus)
> 
> --

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>