[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20161122110557.1533467-2-arnd@arndb.de>
Date: Tue, 22 Nov 2016 12:05:41 +0100
From: Arnd Bergmann <arnd@...db.de>
To: Russell King <linux@...linux.org.uk>
Cc: Uwe Kleine-König <uwe@...ine-koenig.org>,
Nicolas Pitre <nico@...aro.org>,
linux-arm-kernel@...ts.infradead.org,
Nicholas Piggin <npiggin@...il.com>, viro@...iv.linux.org.uk,
linux-kbuild@...r.kernel.org, linux-arch@...r.kernel.org,
regressions@...mhuis.info, Arnd Bergmann <arnd@...db.de>,
linux-kernel@...r.kernel.org
Subject: [PATCH 2/2] ARM: move mmiocpy/mmioset exports to io.c
The prototypes for mmioset/mmiocpy are intentionally hidden
inside of inline functions, which breaks the EXPORT_SYMBOL
statements when symbol versioning is enabled.
This moves the two exports from the files that implement the
code into the kernel/io.c file, adding another local declaration
there.
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
arch/arm/kernel/io.c | 7 +++++++
arch/arm/lib/memcpy.S | 1 -
arch/arm/lib/memset.S | 1 -
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/io.c b/arch/arm/kernel/io.c
index eedefe050022..c74746997626 100644
--- a/arch/arm/kernel/io.c
+++ b/arch/arm/kernel/io.c
@@ -82,3 +82,10 @@ void _memset_io(volatile void __iomem *dst, int c, size_t count)
}
}
EXPORT_SYMBOL(_memset_io);
+
+/* can't export them from memcpy.S/memset.S because of hidden declaration */
+void mmioset(void __iomem *addr, unsigned int c, size_t n);
+EXPORT_SYMBOL(mmioset);
+
+void mmiocpy(void *dest, const void __iomem *src, size_t n);
+EXPORT_SYMBOL(mmiocpy);
diff --git a/arch/arm/lib/memcpy.S b/arch/arm/lib/memcpy.S
index 1be5b6ddf37c..1f822fc52400 100644
--- a/arch/arm/lib/memcpy.S
+++ b/arch/arm/lib/memcpy.S
@@ -70,4 +70,3 @@ ENTRY(memcpy)
ENDPROC(memcpy)
ENDPROC(mmiocpy)
EXPORT_SYMBOL(memcpy)
-EXPORT_SYMBOL(mmiocpy)
diff --git a/arch/arm/lib/memset.S b/arch/arm/lib/memset.S
index 7b72044cba62..6f075ca09abc 100644
--- a/arch/arm/lib/memset.S
+++ b/arch/arm/lib/memset.S
@@ -137,4 +137,3 @@ UNWIND( .fnend )
ENDPROC(memset)
ENDPROC(mmioset)
EXPORT_SYMBOL(memset)
-EXPORT_SYMBOL(mmioset)
--
2.9.0
Powered by blists - more mailing lists