linux-kernel - Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lgwbr9ef.fsf@linux.intel.com>
Date:   Tue, 22 Nov 2016 14:23:04 +0200
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     Stefan Wahren <stefan.wahren@...e.com>,
        John Youn <johnyoun@...opsys.com>,
        Vardan Mikayelyan <mvardan@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Stefan Wahren <stefan.wahren@...e.com>
Subject: Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param


Hi,

Stefan Wahren <stefan.wahren@...e.com> writes:
> Since there is no parameter @value replace it with @legacy.
>
> Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params")
> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>
> ---
>  drivers/usb/dwc2/params.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 11fe68a..10407cb 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -320,7 +320,7 @@ static void dwc2_set_core_param(void *param, u8 size, u64 value)
>   * @size: The size of the core parameter in bytes, or 0 for bool.
>   *
>   * This function looks up @property and sets the @param to that value.
> - * If the property doesn't exist it uses the passed-in @value. It will
> + * If the property doesn't exist it uses the passed-in @legacy value. It will

This doesn't fix any bugs. Also, is @legacy a parameter?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)