linux-kernel - Re: [PATCH v4 00/12] ASoC: add OF graph base simple-card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Nov 2016 01:15:24 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
CC:     Rob Herring <robh+dt@...nel.org>, Mark Brown <broonie@...nel.org>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Simon <horms@...ge.net.au>,
        Laurent <laurent.pinchart@...asonboard.com>,
        Guennadi <g.liakhovetski@....de>,
        "Grant Likely" <grant.likely@...aro.org>,
        Frank Rowand <frowand.list@...il.com>,
        Linux-DT <devicetree@...r.kernel.org>,
        Linux-Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 00/12] ASoC: add OF graph base simple-card


Hi Rob

> These are v4 of OF graph base simple-card patch-set.
> v3 patch had ALSA SoC side prepare patches as [1/xx] - [5/xx],
> but these are already accepted by Mark, thus, this v4 doesn't
> include these.
> Mainly, v4 solved non-OF case compile error which was reported
> by kbuild.

About "type" property on OF graph DT, your opinion was that
it is not needed, and HDMI driver can handle it.
But I noticed that it doesn't work for HDMI sound side.

Below case, port 0 to 3 is for HDMI video out, and port 4 - 5 are for
HDMI sound.
This is located in HDMI video out DT, so, port 0 - 3 can be handled by
HDMI video driver. but port 4 - 5 will be handled by HDMI sound driver
which is very generic driver, and it references this port.
In ALSA side, in this case HDMI sound is handled as 1st and 2nd DAI.
This means, port4 should 1st, port5 should be 2nd in ALSA.
it is impossible to handle it without "type" property.

	ports {
		#address-cells = <1>;
		#size-cells = <0>;

		port@0 {
			reg = <0>;
			du_out_rgb: endpoint {
			};
		};
		port@1 {
			reg = <1>;
			du_out_hdmi0: endpoint {
			};
		};
		port@2 {
			reg = <2>;
			du_out_hdmi1: endpoint {
			};
		};
		port@3 {
			reg = <3>;
			du_out_lvds0: endpoint {
			};
		};
		port@4 {
			type = "sound";
			du_out_hdmi_snd0: endpoint {
			};
		};
		port@5 {
			type = "sound";
			du_out_hdmi_snd1: endpoint {
			};
		};
	};