linux-kernel - Re: [PATCH] orangefs: Axe some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.BSO.2.20.1611221048250.48648@x220.mkb.name>
Date:   Tue, 22 Nov 2016 10:49:23 -0500 (EST)
From:   Martin Brandenburg <martin@...ibond.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
cc:     hubcap@...ibond.com, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] orangefs: Axe some dead code

On Mon, 21 Nov 2016, Christophe JAILLET wrote:

> The "perf_counter_reset" case has already been handled above.
> Moreover "ORANGEFS_PARAM_REQUEST_OP_READAHEAD_COUNT_SIZE" is not a really
> consistent.
> It is likely that this (dead) code is a cut and paste left over.

That's exactly what this is.

Reviewed-by: Martin Brandenburg <martin@...ibond.com>

> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  fs/orangefs/orangefs-sysfs.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/fs/orangefs/orangefs-sysfs.c b/fs/orangefs/orangefs-sysfs.c
> index a799546a67f7..084954448f18 100644
> --- a/fs/orangefs/orangefs-sysfs.c
> +++ b/fs/orangefs/orangefs-sysfs.c
> @@ -609,15 +609,6 @@ static ssize_t sysfs_service_op_store(struct kobject *kobj,
>  			new_op->upcall.req.param.u.value32[0] = val1;
>  			new_op->upcall.req.param.u.value32[1] = val2;
>  			goto value_set;
> -		} else if (!strcmp(attr->attr.name,
> -				   "perf_counter_reset")) {
> -			if ((val > 0)) {
> -				new_op->upcall.req.param.op =
> -				ORANGEFS_PARAM_REQUEST_OP_READAHEAD_COUNT_SIZE;
> -			} else {
> -				rc = 0;
> -				goto out;
> -			}
>  		}
>  
>  	} else if (!strcmp(kobj->name, ACACHE_KOBJ_ID)) {
> -- 
> 2.9.3
> 
>