lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Nov 2016 19:47:52 +0200 From: Vladimir Zapolskiy <vz@...ia.com> To: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Alexandre Belloni <alexandre.belloni@...e-electrons.com>, "David S. Miller" <davem@...emloft.net>, Marcin Wojtas <mw@...ihalf.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] misc: sram: remove useless #ifdef Hi Arnd, On 11/22/2016 04:30 PM, Arnd Bergmann wrote: > A recent patch added a new function that is now unused whenever > CONFIG_OF is disabled: > > drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function] > > There is actually no reason for the #ifdef, because the driver > currently cannot be used in a meaningful way without CONFIG_OF, > and there is no compile-time dependency. > > Removing that #ifdef and the respective of_match_ptr() avoids the > warning and simplifies the driver slightly. > > Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support") I can not find the referenced commit on Torvald's branch, won't it be rebased and get a changed commit hash after merge? > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- The change itself is good, thank you for the fix. Reviewed-by: Vladimir Zapolskiy <vz@...ia.com> -- Best wishes, Vladimir
Powered by blists - more mailing lists