linux-kernel - Re: Linux 4.4.34

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Nov 2016 19:06:05 +0100
From:   Andre Noll <maan@...bingen.mpg.de>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "Duyck, Alexander H" <alexander.h.duyck@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "willemb@...gle.com" <willemb@...gle.com>,
        "jslaby@...e.cz" <jslaby@...e.cz>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "yibyang@...co.com" <yibyang@...co.com>
Subject: Re: Linux 4.4.34

On Tue, Nov 22, 09:56, Eric Dumazet wrote
> >> @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
> >>                 memcpy(key_eth_addrs, &eth->h_dest, sizeof(*key_eth_addrs));
> >>         }
> >>
> >> +       barrier();
> >>  again:
> >>         switch (proto) {
> >>         case htons(ETH_P_IP): {
> >
> > This patch on top of v4.4.34 makes no difference: I'm still getting
> > the panic in eth_type_trans().
> >
> 
> What compiler are you using exactly ?

gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3, as shipped with
Ubuntu-12.04. I've also tried gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3)
4.8.4 from Ubuntu-14.04. No difference.

> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 69e4463a4b1b..48791f372aa2 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -551,6 +551,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
> 
>         key_control->thoff = (u16)nhoff;
>  out:
> +       barrier();
>         key_basic->n_proto = proto;
>         key_basic->ip_proto = ip_proto;

No luck: Still the same panic.

Andre
-- 
Max Planck Institute for Developmental Biology
Spemannstraße 35, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829
http://people.tuebingen.mpg.de/maan/

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)