linux-kernel - Re: Linux 4.4.34

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJDudM=j5S3r2faUfR2X878-3JuLg4H8wZ_jyX-rE8UqA@mail.gmail.com>
Date:   Tue, 22 Nov 2016 10:18:31 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     "Duyck, Alexander H" <alexander.h.duyck@...el.com>
Cc:     "maan@...bingen.mpg.de" <maan@...bingen.mpg.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "willemb@...gle.com" <willemb@...gle.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jslaby@...e.cz" <jslaby@...e.cz>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "yibyang@...co.com" <yibyang@...co.com>
Subject: Re: Linux 4.4.34

On Tue, Nov 22, 2016 at 10:08 AM, Duyck, Alexander H
<alexander.h.duyck@...el.com> wrote:

> Okay I think I have figured it out, but I am not sure what a good
> solution is.
>
> I think the problem is the fact that the keys may not be initialized
> until init_default_flow_dissectors is called and I am not sure that is
> happening before the network interface is trying to do DHCP.
>
> I have to look at the initialization framework to verify if that is the
> case.  It would make sense why I don't usually see it though since I
> usually run igb as a module and that doesn't get loaded until later if
> I am not mistaken.
>

Oh that might be that, goot catch !

Time to try :

diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 69e4463a4b1b..c6d8207ffa7e 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -1013,4 +1013,4 @@ static int __init init_default_flow_dissectors(void)
        return 0;
 }

-late_initcall_sync(init_default_flow_dissectors);
+core_initcall(init_default_flow_dissectors);