linux-kernel - Re: [PATCH] proc: calculate /proc/* and /proc/*/task/* nlink at init time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Nov 2016 19:34:29 +0100
From:   Vegard Nossum <vegard.nossum@...il.com>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] proc: calculate /proc/* and /proc/*/task/* nlink at init time

On 22 November 2016 at 20:55, Alexey Dobriyan <adobriyan@...il.com> wrote:
> Runtime nlink calculation works but meh. I don't know how to do it
> at compile time, but I know how to do it at init time.
>
> Shift "2+" part into init time as a bonus.

Couple of small suggestions:

- rename set_proc_pid_nlink() to proc_pid_nlink_init() to make it 100%
clear it's a one time thing

- move pid_entry_nlink() down to just above where it is called

Either way,

Acked-by/Reviewed-by: Vegard Nossum <vegard.nossum@...cle.com>


Vegard