linux-kernel - [PATCH net] flow_dissect: call init_default_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1479842250.8455.452.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 22 Nov 2016 11:17:30 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Andre Noll <maan@...bingen.mpg.de>, Jiri Pirko <jiri@...nulli.us>
Cc:     "Duyck, Alexander H" <alexander.h.duyck@...el.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        "willemb@...gle.com" <willemb@...gle.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jslaby@...e.cz" <jslaby@...e.cz>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "yibyang@...co.com" <yibyang@...co.com>,
        netdev <netdev@...r.kernel.org>
Subject: [PATCH net] flow_dissect: call init_default_flow_dissectors()
 earlier

From: Eric Dumazet <edumazet@...gle.com>

Andre Noll reported panics after my recent fix (commit 34fad54c2537
"net: __skb_flow_dissect() must cap its return value")

After some more headaches, Alexander root caused the problem to
init_default_flow_dissectors() being called too late, in case
a network driver like IGB is not a module and receives DHCP message
very early.

Fix is to call init_default_flow_dissectors() much earlier,
as it is a core infrastructure and does not depend on another
kernel service.

Fixes: 06635a35d13d4 ("flow_dissect: use programable dissector in skb_flow_dissect and friends")
Signed-off-by: Eric Dumazet <edumazet@...gle.com>
Reported-by: Andre Noll <maan@...bingen.mpg.de>
Diagnosed-by: Alexander Duyck <alexander.h.duyck@...el.com>
---
 net/core/flow_dissector.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 69e4463a4b1b..c6d8207ffa7e 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -1013,4 +1013,4 @@ static int __init init_default_flow_dissectors(void)
 	return 0;
 }
 
-late_initcall_sync(init_default_flow_dissectors);
+core_initcall(init_default_flow_dissectors);