linux-kernel - Re: [PATCH net] flow_dissect: call init_default_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161122.144444.2261159964230408258.davem@davemloft.net>
Date:   Tue, 22 Nov 2016 14:44:44 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     maan@...bingen.mpg.de, jiri@...nulli.us,
        alexander.h.duyck@...el.com, edumazet@...gle.com,
        linux-kernel@...r.kernel.org, ast@...nel.org, willemb@...gle.com,
        gregkh@...uxfoundation.org, jslaby@...e.cz, yibyang@...co.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] flow_dissect: call init_default_flow_dissectors()
 earlier

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 22 Nov 2016 11:17:30 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Andre Noll reported panics after my recent fix (commit 34fad54c2537
> "net: __skb_flow_dissect() must cap its return value")
> 
> After some more headaches, Alexander root caused the problem to
> init_default_flow_dissectors() being called too late, in case
> a network driver like IGB is not a module and receives DHCP message
> very early.
> 
> Fix is to call init_default_flow_dissectors() much earlier,
> as it is a core infrastructure and does not depend on another
> kernel service.
> 
> Fixes: 06635a35d13d4 ("flow_dissect: use programable dissector in skb_flow_dissect and friends")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Andre Noll <maan@...bingen.mpg.de>
> Diagnosed-by: Alexander Duyck <alexander.h.duyck@...el.com>

Applied and queued up for -stable, I'll try to fast-track this.