linux-kernel - Re: [PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of globals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b15c26d8-d904-dcd4-69bd-d098b89d29c9@lechnology.com>
Date:   Tue, 22 Nov 2016 14:46:49 -0600
From:   David Lechner <david@...hnology.com>
To:     Axel Haslam <ahaslam@...libre.com>, gregkh@...uxfoundation.org,
        nsekhar@...com, khilman@...libre.com
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of
 globals

On 11/21/2016 10:30 AM, Axel Haslam wrote:
> Instead of global variables, use the extra_priv_size of
> the ohci driver.
>
> We cannot yet move the ocic mask because this is used on
> the interrupt handler which is registerded through platform

s/registerded/registered/

> data and does not have an hcd pointer. This will be moved
> on a later patch.
>
> Signed-off-by: Axel Haslam <ahaslam@...libre.com>
> ---

Looks good to me (other than the spelling error above).

Tested-by: David Lechner <david@...hnology.com>