linux-kernel - Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161122224615.GJ77253@google.com>
Date:   Tue, 22 Nov 2016 14:46:15 -0800
From:   Brian Norris <computersforpeace@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Colin King <colin.king@...onical.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" ->
 "erasure"

On Tue, Nov 22, 2016 at 01:32:27PM -0800, Joe Perches wrote:
> On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote:
> > Thanks, these all look good but:
> > 
> >  (a) you didn't provide a Signed-off-by and
> >  (b) your patch is full of non-breaking spaces (0xA0), instead of proper
> >  ASCII spaces (0x20)
> > 
> > I feel like we've had this conversation before about your Evolution
> > mailer a long time ago; you still haven't fixed that?
> > 
> > I'm sorry, but I just can't take your patch. I'm not going to hand-edit
> > this one...
> 
> No worries, it was an unsigned patch suggestion, not
> a formal patch.  I know the difference.

OK, understood.

> And have you ever looked at the evolution source code?
> At best, it's pretty convoluted.
> There's _no way_ I want to touch it.

I haven't looked. But by "fixed" I guess I meant "fixed your workflow" :)

Regards,
Brian