[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161123044553.GA19719@sejong>
Date: Wed, 23 Nov 2016 13:45:53 +0900
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
CC: Steven Rostedt <rostedt@...dmis.org>,
<linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...nel.org>,
Jiri Olsa <jolsa@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] tools lib traceevent: Add retrieval of preempt count
and latency flags
Hi Arnaldo and Steve,
On Tue, Nov 22, 2016 at 03:06:24PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 22, 2016 at 11:31:58AM -0500, Steven Rostedt escreveu:
> >
> > Add a way to retrieve the preempt count as well as the latency flags from a
> > pevent_record.
> >
> > int pevent_data_preempt_count(pevent, record);
> >
> > returns the preempt count of a record.
> >
> > int pevent_data_flags(pevent, record);
> >
> > returns the latency flags for a record.
>
> Namhyung, I'm preemptively adding your Acked-by, ok?
Sure.
Acked-by: Namhyung Kim <namhyung@...nel.org>
Thanks,
Namhyung
>
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> > ---
> > tools/lib/traceevent/event-parse.c | 30 ++++++++++++++++++++++++++++--
> > tools/lib/traceevent/event-parse.h | 2 ++
> > 2 files changed, 30 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> > index 664c90c8e22b..6e2dfcbf9e30 100644
> > --- a/tools/lib/traceevent/event-parse.c
> > +++ b/tools/lib/traceevent/event-parse.c
> > @@ -5191,11 +5191,11 @@ struct event_format *pevent_data_event_from_type(struct pevent *pevent, int type
> > }
> >
> > /**
> > - * pevent_data_pid - parse the PID from raw data
> > + * pevent_data_pid - parse the PID from record
> > * @pevent: a handle to the pevent
> > * @rec: the record to parse
> > *
> > - * This returns the PID from a raw data.
> > + * This returns the PID from a record.
> > */
> > int pevent_data_pid(struct pevent *pevent, struct pevent_record *rec)
> > {
> > @@ -5203,6 +5203,32 @@ int pevent_data_pid(struct pevent *pevent, struct pevent_record *rec)
> > }
> >
> > /**
> > + * pevent_data_prempt_count - parse the preempt count from the record
> > + * @pevent: a handle to the pevent
> > + * @rec: the record to parse
> > + *
> > + * This returns the preempt count from a record.
> > + */
> > +int pevent_data_prempt_count(struct pevent *pevent, struct pevent_record *rec)
> > +{
> > + return parse_common_pc(pevent, rec->data);
> > +}
> > +
> > +/**
> > + * pevent_data_flags - parse the latency flags from the record
> > + * @pevent: a handle to the pevent
> > + * @rec: the record to parse
> > + *
> > + * This returns the latency flags from a record.
> > + *
> > + * Use trace_flag_type enum for the flags (see event-parse.h).
> > + */
> > +int pevent_data_flags(struct pevent *pevent, struct pevent_record *rec)
> > +{
> > + return parse_common_flags(pevent, rec->data);
> > +}
> > +
> > +/**
> > * pevent_data_comm_from_pid - return the command line from PID
> > * @pevent: a handle to the pevent
> > * @pid: the PID of the task to search for
> > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
> > index 9ffde377e89d..82b83c4d621c 100644
> > --- a/tools/lib/traceevent/event-parse.h
> > +++ b/tools/lib/traceevent/event-parse.h
> > @@ -712,6 +712,8 @@ void pevent_data_lat_fmt(struct pevent *pevent,
> > int pevent_data_type(struct pevent *pevent, struct pevent_record *rec);
> > struct event_format *pevent_data_event_from_type(struct pevent *pevent, int type);
> > int pevent_data_pid(struct pevent *pevent, struct pevent_record *rec);
> > +int pevent_data_prempt_count(struct pevent *pevent, struct pevent_record *rec);
> > +int pevent_data_flags(struct pevent *pevent, struct pevent_record *rec);
> > const char *pevent_data_comm_from_pid(struct pevent *pevent, int pid);
> > struct cmdline;
> > struct cmdline *pevent_data_pid_from_comm(struct pevent *pevent, const char *comm,
> > --
> > 2.1.0
> >
Powered by blists - more mailing lists