linux-kernel - Re: [LKP] [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFx9q2xi1oi2j5QcYhMV490oj9CQ4N_OEXzC-3b6GeUQug@mail.gmail.com>
Date:   Tue, 22 Nov 2016 23:07:16 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Fengguang Wu <fengguang.wu@...el.com>
Cc:     kernel test robot <xiaolong.ye@...el.com>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexander Duyck <alexander.h.duyck@...el.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>, LKP <lkp@...org>
Subject: Re: [LKP] [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

On Tue, Nov 22, 2016 at 10:44 PM, Fengguang Wu <fengguang.wu@...el.com> wrote:
>
> On Tue, Nov 22, 2016 at 02:04:42PM -0800, Linus Torvalds wrote:
>
>> I also noticed that the kernel test robot had screwed up the
>> participants list for some reason, and had
>>
>>  "Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>, David S.
>> Miller" <davem@...emloft.net>
>>
>> as one of the participants. So there's some odd commit parsing issue
>> there somewhere. But Alexander seems to have seen this report despite
>> that, it just never went anywhere that I can tell.
>
>
> Yeah the robot will CC all "Acked-by" people in the bug reports.
>
> Shall we limit it to the below TO/CC list?

No. We do want to keep the Acked-by's on the cc.

But you missed the real problem.

It *didn't* cc the acked-by. Look closer. What happened was that it cc'd this:

 "Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>, David S. Miller"

 <davem@...emloft.net>

ie there is only _one_ email address (that of davem@...emloft.net),
and the whole "Acked-by: Alexander Duyck <...>" part is quoted as the
_name_ of that email address.

At least that's what the headers look like for me in the original report:

   From: kernel test robot <xiaolong.ye@...el.com>
   To: Eric Dumazet <edumazet@...gle.com>
   Cc: lkp@...org, Linus Torvalds <torvalds@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>, Alexei Starovoitov
<ast@...nel.org>, Willem de Bruijn <willemb@...gle.com>, "Acked-by:
Alexander Duyck <alexander.h.duyck@...el.com>, David S. Miller"
<davem@...emloft.net>

Notice the quoting of that last "name".

              Linus