linux-kernel - Re: [v7] QE: remove PPCisms for QE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161123073528.GA3785@home.buserror.net>
Date:   Wed, 23 Nov 2016 01:35:28 -0600
From:   Scott Wood <oss@...error.net>
To:     Zhao Qiang <qiang.zhao@....com>
Cc:     balbi@...nel.org, gregkh@...uxfoundation.org, xiaobo.xie@....com,
        linux-kernel@...r.kernel.org, pku.leo@...il.com,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [v7] QE: remove PPCisms for QE

On Wed, Sep 28, 2016 at 11:15:31AM +0800, Zhao Qiang wrote:
> QE was supported on PowerPC, and dependent on PPC,
> Now it is supported on other platforms. so remove PPCisms.
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@....com>
> ---

Changelog should be something like:

soc/fsl/qe: Cleanups and portability fixes

QE was supported on PowerPC, and dependent on PPC.  In preparation for
supporting on other platforms, remove some PPCisms.

The PPC kconfig dependency is moved from the QE core into the individual
QE peripheral drivers, to allow portability work to occur on them
separately.
    
> diff --git a/include/soc/fsl/qe/qe.h b/include/soc/fsl/qe/qe.h
> index 70339d7..f7a14f2 100644
> --- a/include/soc/fsl/qe/qe.h
> +++ b/include/soc/fsl/qe/qe.h
> @@ -21,7 +21,6 @@
>  #include <linux/spinlock.h>
>  #include <linux/errno.h>
>  #include <linux/err.h>
> -#include <asm/cpm.h>
>  #include <soc/fsl/qe/immap_qe.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>

When building corenet32_smp_defconfig, I get this:

/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:262:31: error: 'BD_SC_READY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:266:31: error: 'BD_SC_WRAP' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:348:3: error: 'BD_SC_READY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:350:31: error: 'BD_SC_WRAP' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:477:16: error: 'BD_SC_EMPTY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:9: error: 'BD_SC_BR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:20: error: 'BD_SC_FR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:31: error: 'BD_SC_PR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:42: error: 'BD_SC_OV' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:512:3: error: 'BD_SC_ID' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:514:31: error: 'BD_SC_WRAP' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:605:26: error: 'BD_SC_EMPTY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:605:40: error: 'BD_SC_INTRPT' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:613:25: error: 'BD_SC_WRAP' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:926:27: error: 'BD_SC_EMPTY' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:926:41: error: 'BD_SC_OV' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:928:29: error: 'BD_SC_FR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:928:40: error: 'BD_SC_PR' undeclared (first use in this function)
/home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:930:29: error: 'BD_SC_BR' undeclared (first use in this function)

-Scott