linux-kernel - Re: [PATCH 07/10] mm: warn about vfree from atomic context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161123083949.GD16966@lst.de>
Date:   Wed, 23 Nov 2016 09:39:49 +0100
From:   Christoph Hellwig <hch@....de>
To:     Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:     Christoph Hellwig <hch@....de>, akpm@...ux-foundation.org,
        joelaf@...gle.com, jszhang@...vell.com, chris@...is-wilson.co.uk,
        joaodias@...gle.com, linux-mm@...ck.org,
        linux-rt-users@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/10] mm: warn about vfree from atomic context

On Tue, Nov 22, 2016 at 07:35:34PM +0300, Andrey Ryabinin wrote:
> This one is wrong. We still can call vfree() from interrupt context.
> So WARN_ON_ONCE(in_atomic() && !in_interrupt()) would be correct,
> but also redundant. DEBUG_ATOMIC_SLEEP=y should catch illegal vfree() calls.
> Let's just drop this patch, ok?

Ok, fine.