linux-kernel - Re: [PATCH 01/10] perf, tools: Factor out scale conversion code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161123092639.GA19377@krava>
Date:   Wed, 23 Nov 2016 10:26:39 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 01/10] perf, tools: Factor out scale conversion code

On Fri, Nov 18, 2016 at 04:36:11PM -0800, Andi Kleen wrote:

SNIP

>  	return ret;
> @@ -261,6 +267,12 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
>  	alias->long_desc = long_desc ? strdup(long_desc) :
>  				desc ? strdup(desc) : NULL;
>  	alias->topic = topic ? strdup(topic) : NULL;
> +	if (unit) {
> +		if (convert_scale(unit, &unit, &alias->scale) < 0)
> +			return -1;
> +		snprintf(alias->unit, sizeof(alias->unit), "%s", unit);
> +	}
> +	alias->str = strdup(val);

  CC       util/pmu.o
util/pmu.c: In function ‘__perf_pmu__new_alias’:
util/pmu.c:270:6: error: ‘unit’ undeclared (first use in this function)
  if (unit) {


jirka