linux-kernel - Re: [patch 1/5] powercap/intel_rapl: Add missing domain data update on hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161122172217.28e77ed6@jacob-builder>
Date:   Tue, 22 Nov 2016 17:22:17 -0800
From:   Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, Rafael Wysocki <rjw@...k.pl>,
        x86@...nel.org, Peter Zijlstra <peterz@...radead.org>,
        linux-pm@...r.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@...el.com>,
        jacob.jun.pan@...ux.intel.com
Subject: Re: [patch 1/5] powercap/intel_rapl: Add missing domain data update
 on hotplug

On Tue, 22 Nov 2016 21:15:58 -0000
Thomas Gleixner <tglx@...utronix.de> wrote:

> The more interesting question is why rapl_update_domain_data() exists
> at all as nothing ever uses that data.

You are right, initial domain data are read at initialization time but
not used. I seem to remember I did this trying to save and restore rapl
raw settings between module load and unload. But I forgot to use it
for restore :(.

Thanks,

Jacob