linux-kernel - Re: [PATCH] power: ab8500_btemp: use builtin_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161123154711.spvfn2iguovkgp4h@earth>
Date:   Wed, 23 Nov 2016 16:47:11 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Geliang Tang <geliangtang@...il.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: ab8500_btemp: use builtin_platform_driver

Hi,

On Wed, Nov 23, 2016 at 10:56:52PM +0800, Geliang Tang wrote:
> Use builtin_platform_driver() helper to simplify the code.
> 
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
>
> [...]
>
> +builtin_platform_driver(ab8500_btemp_driver);
>  module_exit(ab8500_btemp_exit);

builtin_XYZ() followed by module_XYZ() is obviously wrong. I think
the driver could be made tristate, so lets do that (and then use
module_platform_driver() instead).

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)