linux-kernel - Re: [PATCH v2 0/6] staging: speakup: speakup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161123155632.GC8719@kroah.com>
Date:   Wed, 23 Nov 2016 16:56:32 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Fleetwood Farm <waltfeasel@...il.com>
Cc:     Samuel Thibault <samuel.thibault@...-lyon.org>,
        devel@...verdev.osuosl.org, kirk@...sers.ca,
        linux-kernel@...r.kernel.org, w.d.hubbs@...il.com,
        chris@...-brannons.com, speakup@...ux-speakup.org
Subject: Re: [PATCH v2 0/6] staging: speakup: speakup_soft.c checkpatch
 modifications

On Wed, Nov 23, 2016 at 05:52:25AM -0500, Fleetwood Farm wrote:
> On Nov 23, 2016 4:08 AM, "Greg KH" <gregkh@...uxfoundation.org> wrote:
> >
> > On Mon, Nov 21, 2016 at 10:19:19AM -0500, Walt Feasel wrote:
> > > Make Linux kernel style modifications for speak_soft.c to include:
> > >
> > > Space around operator
> > > Logical continuation
> > > Multiple blank lines
> > > Blank line after {
> > > comment modifications
> > > Align parenthesis
> >
> > Ok, now that you have a bunch of cleanup patches accepted, why not work
> > on some "real" code changes?  There's no need to fix all of the coding
> > style issues in drivers/staging/ at once, leave some for other people to
> > learn on :)
> >
> > thanks,
> >
> > greg k-h
> 
> Well, I have around 40 more patches already prepared waiting for my limit to
> clear (which just did) and about 12 more files left to checkpatch in speakup.
> I am currently waiting on the newbies administer to clear my sent emails asking
> advice on if some of my tougher challenges (octals and CamelCase) are done
> correctly.

"newbies administrator"?

> I am also currently waiting on the u-boot mailing list administer to do the
> same on some of my patches.
> I also am doing some online 'c' courses to increase (get) my skills set.
> What type of "real" code changes did you have in mind with my limited skill
> set?

I'd strongly suggest working on some userspace programs to get a
less-limited skill set :)  Then find some area of the kernel you are
interested in, and help out there.  Speakup really can use the help, and
the community of users of their devices is very good, so any real work
you can do there would always be greatly appreciated.

best of luck,

greg k-h