linux-kernel - Re: [PATCH KERNEL] xen/events: use xen_vcpu_id mapping for EVTCHNOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79cefa82-e3ff-3b0a-89fd-562eb46afee2@oracle.com>
Date:   Wed, 23 Nov 2016 11:17:22 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        xen-devel@...ts.xenproject.org
Cc:     linux-kernel@...r.kernel.org, Juergen Gross <jgross@...e.com>,
        David Vrabel <david.vrabel@...rix.com>
Subject: Re: [PATCH KERNEL] xen/events: use xen_vcpu_id mapping for
 EVTCHNOP_status

On 11/23/2016 07:38 AM, Vitaly Kuznetsov wrote:
> EVTCHNOP_status hypercall returns Xen's idea of vcpu id so we need to
> compare it against xen_vcpu_id mapping, not the Linux cpu id.
>
> Suggested-by: Radim Krcmar <rkrcmar@...hat.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>


> ---
>  drivers/xen/events/events_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
> index 9ecfcdc..137bd0e 100644
> --- a/drivers/xen/events/events_base.c
> +++ b/drivers/xen/events/events_base.c
> @@ -948,7 +948,7 @@ static int find_virq(unsigned int virq, unsigned int cpu)
>  			continue;
>  		if (status.status != EVTCHNSTAT_virq)
>  			continue;
> -		if (status.u.virq == virq && status.vcpu == cpu) {
> +		if (status.u.virq == virq && status.vcpu == xen_vcpu_nr(cpu)) {
>  			rc = port;
>  			break;
>  		}