linux-kernel - Re: [PATCH] drivers: net: davinci_mdio: use builtin_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00cc7fb8-6c2f-16ae-c589-bd9ad5bd7beb@ti.com>
Date:   Wed, 23 Nov 2016 11:22:32 -0600
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Geliang Tang <geliangtang@...il.com>,
        Mugunthan V N <mugunthanvnm@...com>
CC:     <linux-omap@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: net: davinci_mdio: use builtin_platform_driver



On 11/23/2016 08:45 AM, Geliang Tang wrote:
> Use builtin_platform_driver() helper to simplify the code.

Not sure about this. We do support this driver to be a module.

>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>  drivers/net/ethernet/ti/davinci_mdio.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
> index 33df340..b3f0a12 100644
> --- a/drivers/net/ethernet/ti/davinci_mdio.c
> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
> @@ -536,11 +536,7 @@ static struct platform_driver davinci_mdio_driver = {
>  	.remove = davinci_mdio_remove,
>  };
>
> -static int __init davinci_mdio_init(void)
> -{
> -	return platform_driver_register(&davinci_mdio_driver);
> -}
> -device_initcall(davinci_mdio_init);
> +builtin_platform_driver(davinci_mdio_driver);
>
>  static void __exit davinci_mdio_exit(void)
>  {
>

-- 
regards,
-grygorii