linux-kernel - Re: [PATCH 2/2] pci: Don't set RCB bit in LNKCTL if the upstream bridge hasn't

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161123194928.GG16033@bhelgaas-glaptop.roam.corp.google.com>
Date:   Wed, 23 Nov 2016 13:49:28 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Alexander Graf <agraf@...e.de>,
        Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH 2/2] pci: Don't set RCB bit in LNKCTL if the upstream
 bridge hasn't

On Wed, Nov 23, 2016 at 11:31:52AM -0600, Bjorn Helgaas wrote:
> On Mon, Nov 21, 2016 at 10:53:52AM -0600, Bjorn Helgaas wrote:
> > On Wed, Nov 16, 2016 at 12:11:58PM -0600, Bjorn Helgaas wrote:
> > > Hi Johannes,
> > > 
> > > On Wed, Nov 02, 2016 at 04:35:52PM -0600, Johannes Thumshirn wrote:
> > > > The Read Completion Boundary (RCB) bit must only be set on a device or
> > > > endpoint if it is set on the root complex.
> > ...
> 
> > Here's the fixed one.
> 
> I applied the one below to for-linus for v4.9.
> 
> I did tweak the preceding patch to only share pcie_find_root_port()
> inside drivers/pci -- moved the declaration from include/linux/pci.h
> to drivers/pci/pci.h and moved the definition to drivers/pci/search.c.
> 
> I don't think it needs to be visible to the whole kernel.

Sigh, I guess it *does*, because the aer_inject user can be a module.
I'll fix that.

Bjorn