linux-kernel - Re: question about sound/soc/intel/boards/mfld

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161123034157.GA2698@localhost>
Date:   Wed, 23 Nov 2016 09:11:57 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     "Jie, Yang" <yang.jie@...el.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: question about sound/soc/intel/boards/mfld_machine.c

On Mon, Nov 21, 2016 at 07:19:43AM +0530, Jie, Yang wrote:
> > -----Original Message-----
> > From: Julia Lawall [mailto:julia.lawall@...6.fr]
> > Sent: Sunday, November 20, 2016 1:34 AM
> > To: lgirdwood@...il.com; broonie@...nel.org; perex@...ex.cz;
> > tiwai@...e.com; Jie, Yang <yang.jie@...el.com>
> > Cc: alsa-devel@...a-project.org; linux-kernel@...r.kernel.org
> > Subject: question about sound/soc/intel/boards/mfld_machine.c
> > 
> > Hello,
> > 
> > I wonder if the file sound/soc/intel/boards/mfld_machine.c is useful?
> > Until:
> > 
> > commit e56c72d5f201044b14191c5b83a25e17f2d68ccf
> > Author: Jie Yang <yang.jie@...el.com>
> > Date:   Thu Apr 2 15:37:02 2015 +0800
> > 
> >     ASoC: Intel: create boards folder and move sst boards files in
> > 
> > it was in the directory sound/soc/intel and mentioned in
> > sound/soc/intel/Makefile.  The above patch moved it to
> > sound/soc/intel/boards/, but didn't adjust its Makefile entry.  The patch:
> > 
> > commit b97169da06992ef04081e66ed22bbdb23dbf6610
> > Author: Jie Yang <yang.jie@...el.com>
> > Date:   Thu Apr 2 15:37:04 2015 +0800
> > 
> >     ASoC: Intel: create atom folder and move atom platform files in
> > 
> > removed it from sound/soc/intel/Makefile, but didn't move it anywhere.
> > As far as I can tell, there is currently no make information for the file in the
> > kernel.
> > 
> > Should the file be dropped?
> 
> Thanks for reporting, Julia. I believe this is missed during the folder
> restruction. 
> 
> Hi Vinod, what do you think? If needed, I can add it to intel/Kconfig.

Yeah looks like a miss. This is also a fact that noone is using this, at
least from upstream, so maybe removing it is not such a bad idea..??

-- 
~Vinod