linux-kernel - Re: [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161123230832.anbbhmllij4bxpsh@earth>
Date:   Thu, 24 Nov 2016 00:08:33 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     "Andrew F. Davis" <afd@...com>
Cc:     Pali Rohár <pali.rohar@...il.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: bq27xxx_battery: Fix register map for
 BQ27510 and BQ27520

Hi,

On Fri, Nov 04, 2016 at 01:33:13PM -0500, Andrew F. Davis wrote:
> The BQ27510 and BQ27520 use a slightly different register map than the
> BQ27500, add a new type enum and add these gauges to it.
> 
> Fixes: d74534c27775 ("power: bq27xxx_battery: Add support for additional bq27xxx family devices")
> Based-on-patch-by: Kenneth R. Crudup <kenny@...ix.com>
> Signed-off-by: Andrew F. Davis <afd@...com>
> ---
>  drivers/power/supply/bq27xxx_battery.c     | 41 +++++++++++++++++++++++++++++-
>  drivers/power/supply/bq27xxx_battery_i2c.c |  4 +--
>  include/linux/power/bq27xxx_battery.h      |  3 ++-
>  3 files changed, 44 insertions(+), 4 deletions(-)

Queued into for-next. I think pali's hint, that bq27xxx_battery_overtemp()
should be implemented using a switch-case is valid to make the code more
readable. Please provide this change as follow-up patch.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)