linux-kernel - Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161124051034.GE9376@vireshk-i7>
Date:   Thu, 24 Nov 2016 10:40:34 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Rafael Wysocki <rjw@...ysocki.net>, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Juri Lelli <Juri.Lelli@....com>,
        Robin Randhawa <robin.randhawa@....com>,
        Steve Muckle <smuckle.linux@...il.com>
Subject: Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue
 to SCHED_FIFO task

On 24-11-16, 05:51, Ingo Molnar wrote:
> 
> * Viresh Kumar <viresh.kumar@...aro.org> wrote:
> 
> > +	/*
> > +	 * For Real Time and Deadline tasks, schedutil governor shoots the
> > +	 * frequency to maximum. And special care must be taken to ensure that
> > +	 * this kthread doesn't result in that.
> > +	 *
> > +	 * This is (mostly) guaranteed by the work_in_progress flag. The flag is
> > +	 * updated only at the end of the sugov_work() and before that schedutil
> > +	 * rejects all other frequency scaling requests.
> > +	 *
> > +	 * Though there is a very rare case where the RT thread yields right
> > +	 * after the work_in_progress flag is cleared. The effects of that are
> > +	 * neglected for now.
> > +	 */
> 
> s/schedutil governor/
>   the schedutil governor
> 
> s/And special care must be taken/
>   Special care must be taken
> 
> s/at the end of the sugov_work()/
>   at the end of the sugov_work() function
> 
> s/before that schedutil rejects/
>   before the schedutil governor rejects
> 
> s/Though there is a very rare case where
>   There is a very rare case though, where

Thanks. I will send a fix for this.

-- 
viresh